download_core.js: Download file again if outdated#588
Merged
Conversation
|
rkistner
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
download_core.jsis invoked and a local copy of the core extension already exists, the script currently does nothing. That's fine whendownload_core.jsis used as an install script because we expect that directory to be immutable after the install script ran.Especially when developing on this SDK though, the current behavior can easily lead to situations where the core extension is outdated. This fixes the script to:
To be able to update the expected hashes after update, the script has an
update_hashessubcommand that will print all hashes of the current version.